Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

JIRA link

TD-5135

Description

Universal fix implemented for handling non-matching stored filter values.
GetFilterString(+) modified to display filters which are exist in the available filters. Also this function calls sub method to remove duplicate filters.
Code changes are applied in the following areas:

  1. All delegates
  2. All delegates-> Email
  3. Delegate activities
  4. Activity delegates
  5. course setup
  6. Delegate groups
  7. Group delegates-> Add
  8. Group courses-> Add
  9. Centre administrators
  10. Find your centre
  11. Welcome->Learning content->See more

Screenshots

N/A

Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review December 20, 2024 07:07
@rshrirohit rshrirohit merged commit 9ed1154 into DLS-Release-v1.1.1 Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants